diff options
| author | Adrian Hunter <adrian.hunter@intel.com> | 2016-12-02 15:14:22 +0200 |
|---|---|---|
| committer | Stefan Agner <stefan.agner@toradex.com> | 2018-03-23 09:23:59 +0100 |
| commit | e08513e2a5b489b6780e5a9d96c6af87ea5212e5 (patch) | |
| tree | 353eda4bbf9769d3448efc7aa3563f979d3cccf6 | |
| parent | 25ad1c3f7fe5fc7e5d41e1c6e3f79994ffda6c80 (diff) | |
mmc: sdhci: Always allow tuning to fall back to fixed sampling
SDHCI falls back to fixed sampling if there is an error during tuning.
However it also reports an error unless there is periodic re-tuning.
That is not the best option because:
a) there is a reasonable chance that fixed sampling will work, especially
at room temperature.
b) re-tuning will be done again anyway if there are CRC errors.
Change to return no error always when falling back to fixed sampling.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
(cherry picked from commit 0760c355525c08dd598e86edb2a310688ac8af4c)
| -rw-r--r-- | drivers/mmc/host/sdhci.c | 23 |
1 files changed, 3 insertions, 20 deletions
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 1a067bbcdab2..b45f2b5e4d52 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2039,8 +2039,6 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode) sdhci_do_reset(host, SDHCI_RESET_CMD); sdhci_do_reset(host, SDHCI_RESET_DATA); - err = -EIO; - if (cmd.opcode != MMC_SEND_TUNING_BLOCK_HS200) goto out; @@ -2076,26 +2074,11 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode) ctrl &= ~SDHCI_CTRL_TUNED_CLK; sdhci_writew(host, ctrl, SDHCI_HOST_CONTROL2); } - if (!(ctrl & SDHCI_CTRL_TUNED_CLK)) { - pr_info(DRIVER_NAME ": Tuning procedure" - " failed, falling back to fixed sampling" - " clock\n"); - err = -EIO; - } + if (!(ctrl & SDHCI_CTRL_TUNED_CLK)) + pr_info(DRIVER_NAME ": Tuning procedure failed, falling back to fixed sampling clock\n"); out: - if (tuning_count) { - /* - * In case tuning fails, host controllers which support - * re-tuning can try tuning again at a later time, when the - * re-tuning timer expires. So for these controllers, we - * return 0. Since there might be other controllers who do not - * have this capability, we return error for them. - */ - err = 0; - } - - host->mmc->retune_period = err ? 0 : tuning_count; + host->mmc->retune_period = tuning_count; sdhci_writel(host, host->ier, SDHCI_INT_ENABLE); sdhci_writel(host, host->ier, SDHCI_SIGNAL_ENABLE); |