diff options
| author | Chen Gang <gang.chen@asianux.com> | 2013-06-08 11:57:39 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-06-08 22:20:59 -0700 |
| commit | 5aaf4c27f38e2a40f5b25fd3c43cb4d57b06ae59 (patch) | |
| tree | 2c88ae512ebe0feb2f24317cb06ee4daa15cfca4 | |
| parent | 7b1a5e2f4f5afde4f1dadf58223c2f293208293b (diff) | |
drivers: staging: dgrp: using time_is_before_jiffies() instead of open coding 'jiffies'
Need use the proper jiffy comparison macros/functions instead of open
coding 'jiffies'.
The original 'comparation' is always true.
The related warning (with 'EXTRA_CFLAGS=-W')
drivers/staging/dgrp/dgrp_net_ops.c:1610:10: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/dgrp/dgrp_net_ops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/dgrp/dgrp_net_ops.c b/drivers/staging/dgrp/dgrp_net_ops.c index 7a0d72d70acc..33ac7fb88cbd 100644 --- a/drivers/staging/dgrp/dgrp_net_ops.c +++ b/drivers/staging/dgrp/dgrp_net_ops.c @@ -1607,7 +1607,7 @@ static int dgrp_send(struct nd_struct *nd, long tmax) if ((ch->ch_pun.un_flag & UN_LOW) != 0 ? (n <= TBUF_LOW) : (ch->ch_pun.un_flag & UN_TIME) != 0 ? - ((jiffies - ch->ch_waketime) >= 0) : + time_is_before_jiffies(ch->ch_waketime) : (n == 0 && ch->ch_s_tpos == ch->ch_s_tin) && ((ch->ch_pun.un_flag & UN_EMPTY) != 0 || ((ch->ch_tun.un_open_count && |