summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonathan Corbet <corbet@lwn.net>2011-11-02 09:15:16 +1100
committerMarcel Ziswiler <marcel.ziswiler@toradex.com>2017-12-21 02:03:46 +0100
commit9c3dac3965c611945c934b5b589e3720b33bd85f (patch)
tree1fd835668567d7901b25348c203eb4f7c0ce9417
parent288195c744c8a2c7bc54373d12d95ac536416036 (diff)
crypto: user - Fix rwsem leak in crypto_user
The list_empty case in crypto_alg_match() will return without calling up_read() on crypto_alg_sem. We could do the "goto out" routine, but the function will clearly do the right thing with that test simply removed. Signed-off-by: Jonathan Corbet <corbet@lwn.net> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> (cherry picked from commit fb223c32b4d3ee593c8dce07e983680d06abe387) Signed-off-by: Dominik Sliwa <dominik.sliwa@toradex.com> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
-rw-r--r--crypto/crypto_user.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c
index 2abca78..0605a2b 100644
--- a/crypto/crypto_user.c
+++ b/crypto/crypto_user.c
@@ -44,9 +44,6 @@ static struct crypto_alg *crypto_alg_match(struct crypto_user_alg *p, int exact)
down_read(&crypto_alg_sem);
- if (list_empty(&crypto_alg_list))
- return NULL;
-
list_for_each_entry(q, &crypto_alg_list, cra_list) {
int match = 0;