summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMiklos Szeredi <mszeredi@redhat.com>2017-02-16 17:49:02 +0100
committerSasha Levin <alexander.levin@verizon.com>2017-03-06 17:31:14 -0500
commit4cc0d2f4a8c1b97771f16ce65848dd30e5731df7 (patch)
treebf4ae07fed3e46a6b59f16bcd645d4c3a40e9bf4
parent64c46de968deccbb7a9bbd42c93f0399aea1036c (diff)
vfs: fix uninitialized flags in splice_to_pipe()
[ Upstream commit 5a81e6a171cdbd1fa8bc1fdd80c23d3d71816fac ] Flags (PIPE_BUF_FLAG_PACKET, PIPE_BUF_FLAG_GIFT) could remain on the unused part of the pipe ring buffer. Previously splice_to_pipe() left the flags value alone, which could result in incorrect behavior. Uninitialized flags appears to have been there from the introduction of the splice syscall. Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> Cc: <stable@vger.kernel.org> # 2.6.17+ Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
-rw-r--r--fs/splice.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/splice.c b/fs/splice.c
index e7522c486068..6ec6054df138 100644
--- a/fs/splice.c
+++ b/fs/splice.c
@@ -211,6 +211,7 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe,
buf->len = spd->partial[page_nr].len;
buf->private = spd->partial[page_nr].private;
buf->ops = spd->ops;
+ buf->flags = 0;
if (spd->flags & SPLICE_F_GIFT)
buf->flags |= PIPE_BUF_FLAG_GIFT;