diff options
| author | Vlad Yasevich <vladislav.yasevich@hp.com> | 2010-09-15 10:00:26 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-09-26 17:21:35 -0700 |
| commit | ca92b22ffac5a8b47d6be1a6f2e0dbe68b485f18 (patch) | |
| tree | 160c2ef8ac7ec6ef49ee89c7ab7aff78de39069d | |
| parent | bded361d94196ecca089c8a3c28ed60af4906d8f (diff) | |
sctp: Do not reset the packet during sctp_packet_config().
commit 4bdab43323b459900578b200a4b8cf9713ac8fab upstream.
sctp_packet_config() is called when getting the packet ready
for appending of chunks. The function should not touch the
current state, since it's possible to ping-pong between two
transports when sending, and that can result packet corruption
followed by skb overlfow crash.
Reported-by: Thomas Dreibholz <dreibh@iem.uni-due.de>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | net/sctp/output.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/sctp/output.c b/net/sctp/output.c index 5cbda8f1ddfd..d494100956af 100644 --- a/net/sctp/output.c +++ b/net/sctp/output.c @@ -91,7 +91,6 @@ struct sctp_packet *sctp_packet_config(struct sctp_packet *packet, SCTP_DEBUG_PRINTK("%s: packet:%p vtag:0x%x\n", __func__, packet, vtag); - sctp_packet_reset(packet); packet->vtag = vtag; if (ecn_capable && sctp_packet_empty(packet)) { |