diff options
| author | Sasha Levin <sasha.levin@oracle.com> | 2014-03-29 20:39:35 -0400 |
|---|---|---|
| committer | Willy Tarreau <w@1wt.eu> | 2014-05-19 07:54:18 +0200 |
| commit | dfce42782f140401b052eee1aec9b577a5c12c3b (patch) | |
| tree | 275f712eab4e362f3f033c92d81174e4089e6140 | |
| parent | 3979c481572d031934ce63d1e3e40555247a959a (diff) | |
rds: prevent dereference of a NULL device in rds_iw_laddr_check
[ Upstream commit bf39b4247b8799935ea91d90db250ab608a58e50 ]
Binding might result in a NULL device which is later dereferenced
without checking.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>
| -rw-r--r-- | net/rds/iw.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/rds/iw.c b/net/rds/iw.c index db224f7c2937..bff1e4bab51b 100644 --- a/net/rds/iw.c +++ b/net/rds/iw.c @@ -237,7 +237,8 @@ static int rds_iw_laddr_check(__be32 addr) ret = rdma_bind_addr(cm_id, (struct sockaddr *)&sin); /* due to this, we will claim to support IB devices unless we check node_type. */ - if (ret || cm_id->device->node_type != RDMA_NODE_RNIC) + if (ret || !cm_id->device || + cm_id->device->node_type != RDMA_NODE_RNIC) ret = -EADDRNOTAVAIL; rdsdebug("addr %pI4 ret %d node type %d\n", |