summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEva Rachel Retuya <eraretuya@gmail.com>2017-03-20 19:27:05 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-06-24 07:11:14 +0200
commita1d51f7abf710729822bafeb82c664f6657a4db6 (patch)
tree4d72376e161c4c179f338b1be6c6162a767c3dbc
parent773fdcdc0957527577b2f1de994448894f1e3305 (diff)
staging: iio: tsl2x7x_core: Fix standard deviation calculation
commit cf6c77323a96fc40309cc8a4921ef206cccdd961 upstream. Standard deviation is calculated as the square root of the variance where variance is the mean of sample_sum and length. Correct the computation of statP->stddev in accordance to the proper calculation. Fixes: 3c97c08b5735 ("staging: iio: add TAOS tsl2x7x driver") Reported-by: Abhiram Balasubramanian <abhiram@cs.utah.edu> Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: Jonathan Cameron <jic23@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/iio/light/tsl2x7x_core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
index ea15bc1c300c..197201a70d59 100644
--- a/drivers/staging/iio/light/tsl2x7x_core.c
+++ b/drivers/staging/iio/light/tsl2x7x_core.c
@@ -854,7 +854,7 @@ void tsl2x7x_prox_calculate(int *data, int length,
tmp = data[i] - statP->mean;
sample_sum += tmp * tmp;
}
- statP->stddev = int_sqrt((long)sample_sum) / length;
+ statP->stddev = int_sqrt((long)sample_sum / length);
}
/**