summaryrefslogtreecommitdiff
path: root/drivers/ata
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2014-04-20 08:29:21 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-06-07 10:28:08 -0700
commit59516f324f324b6b392b94833da3972e346c5f0c (patch)
tree520285318fafba398448c8a867e081f8ce2f48bc /drivers/ata
parentce5e2b32090d5564d4393b36b5be3b226f4ded4e (diff)
kernfs: add back missing error check in kernfs_fop_mmap()
commit b44b2140265ddfde03acbe809336111d31adb0d1 upstream. While updating how mmap enabled kernfs files are handled by lockdep, 9b2db6e18945 ("sysfs: bail early from kernfs_file_mmap() to avoid spurious lockdep warning") inadvertently dropped error return check from kernfs_file_mmap(). The intention was just dropping "if (ops->mmap)" check as the control won't reach the point if the mmap callback isn't implemented, but I mistakenly removed the error return check together with it. This led to Xorg crash on i810 which was reported and bisected to the commit and then to the specific change by Tobias. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-and-bisected-by: Tobias Powalowski <tobias.powalowski@googlemail.com> Tested-by: Tobias Powalowski <tobias.powalowski@googlemail.com> References: http://lkml.kernel.org/g/533D01BD.1010200@googlemail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/ata')
0 files changed, 0 insertions, 0 deletions