summaryrefslogtreecommitdiff
path: root/drivers/firewire/core-card.c
diff options
context:
space:
mode:
authorOleg Drokin <green@linuxhacker.ru>2011-03-11 04:17:27 +0300
committerStefan Richter <stefanr@s5r6.in-berlin.de>2011-03-14 23:30:57 +0100
commitd838d2c09af0820e306e3e9e31f97e873823b0b4 (patch)
treeb51cb6854bac7282c925f67b612ee22e946445c2 /drivers/firewire/core-card.c
parentb6258fc1feabda868694ad5fdc7ca8edf3ef30ec (diff)
firewire: ohci: Misleading kfree in ohci.c::pci_probe/remove
It seems drivers/firewire/ohci.c is making some optimistic assumptions about struct fw_ohci and that member "card" will always remain the first member of the struct. Plus it's probably going to confuse a lot of static code analyzers too. So I wonder if there is a good reason not to free the ohci struct just like it was allocated instead of the tricky &ohci->card way? Signed-off-by: Oleg Drokin <green@linuxhacker.ru> It is perhaps just a rudiment from before mainline submission of the driver. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire/core-card.c')
0 files changed, 0 insertions, 0 deletions