diff options
| author | Stefan Agner <stefan.agner@toradex.com> | 2016-11-23 16:14:23 -0800 |
|---|---|---|
| committer | Philippe Schenker <philippe.schenker@toradex.com> | 2019-05-24 11:34:14 +0200 |
| commit | 3303db8896a1d050ba7858ac680a328c875fe238 (patch) | |
| tree | 32838d25c9eb493f270f37e3a21a649a1cc60547 /drivers/gpio | |
| parent | b38505783e89d5196f5295810b9d98ef43894367 (diff) | |
gpio: mxc: clear interrupt mask/status optionally
Add a kernel parameter ("gpio-mxc.noclearirq") to disable
unconditional interrupt mask/clearing. This is useful when a
second CPU (the Cortex-M4) is accessing the same GPIO bank.
Using the same GPIO bank from the Cortex-A7 and M4 sounds risky,
but it seems to work quite well. Most registers are write only
(e.g. interrupt status register can be cleared with a single
write), which makes them safe for concurrent access. However,
sharing a single GPIO bank between two cores does not allow to
use the Resource Domain Controller. Hence for secure applications
assigning a dedicated GPIO bank is still preferable.
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
(cherry picked from commit 4cfa939c693b20ca213f054c1dfe5583d966beb4)
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpio-mxc.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c index 10d189072dd3..d9eae362e0a5 100644 --- a/drivers/gpio/gpio-mxc.c +++ b/drivers/gpio/gpio-mxc.c @@ -20,6 +20,7 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ +#include <linux/moduleparam.h> #include <linux/clk.h> #include <linux/err.h> #include <linux/init.h> @@ -42,6 +43,10 @@ #include <soc/imx8/sc/svc/irq/api.h> #endif +static bool noclearirq = false; +module_param(noclearirq, bool, 0); +MODULE_PARM_DESC(noclearirq, "do not clear IRQ mask/status on probe"); + enum mxc_gpio_hwtype { IMX1_GPIO, /* runs on i.mx1 */ IMX21_GPIO, /* runs on i.mx21 and i.mx27 */ @@ -634,8 +639,10 @@ static int mxc_gpio_probe(struct platform_device *pdev) goto out_pm_dis; /* disable the interrupt and clear the status */ - writel(0, port->base + GPIO_IMR); - writel(~0, port->base + GPIO_ISR); + if (!noclearirq) { + writel(0, port->base + GPIO_IMR); + writel(~0, port->base + GPIO_ISR); + } if (mxc_gpio_hwtype == IMX21_GPIO) { /* |