summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
diff options
context:
space:
mode:
authorJordan Crouse <jcrouse@codeaurora.org>2018-08-28 15:23:04 -0600
committerRob Clark <robdclark@gmail.com>2018-10-03 20:24:50 -0400
commitd270bdf41e4ac05f16c53482a5769819b040806f (patch)
tree1e011c86691eb714aff4d7bb574c2132b3e4de72 /drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
parent96fc56a775c1e44c0e3c0119f2cd3d77431c4569 (diff)
drm/msm/dpu: Remove dpu_mdss_isr when dpu_mdss_destroy is called
The MDSS device is created before the MSM driver attempts to bind the sub components. If any of the components return -EPROBE_DEFER the MDSS device is destroyed and tried again later. If this happens the dpu_mdss_isr interrupt created from the DPU MDSS is not freed when the MDSS device is destroyed and has a risk of triggering later and hitting a fault by accessing a mmio region that no longer exists. Even if the interrupt isn't triggered by accident when the device attempts to reprobe it would error out when it tries to re-register the interrupt so unconditionally removing it in the destroy is the right move. Switch the device managed dpu_mdss_isr to be unmanaged and add a free_irq() in the mdss destroy function. Reviewed-by: Sean Paul <seanpaul@chromium.org> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> Signed-off-by: Sean Paul <seanpaul@chromium.org> Signed-off-by: Rob Clark <robdclark@gmail.com>
Diffstat (limited to 'drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c')
0 files changed, 0 insertions, 0 deletions