summaryrefslogtreecommitdiff
path: root/drivers/hid/hid-picolcd_lcd.c
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-19 18:30:22 +0100
committerJiri Kosina <jkosina@suse.com>2015-06-29 14:51:12 +0200
commit4b8a8262086ece4b7eb34bd2e40cce3b3c9c7079 (patch)
treef7c6bd8249ca0daf1c9632e9a103e89f1787276f /drivers/hid/hid-picolcd_lcd.c
parent67db8a8086e9b865533348954f5547f1e433101e (diff)
HID: picoLCD: Deletion of unnecessary checks before three function calls
The functions backlight_device_unregister(), lcd_device_unregister() and rc_unregister_device() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Reviewed-by: Bruno Prémont <bonbons@linux-vserver.org> Signed-off-by: Jiri Kosina <jkosina@suse.com>
Diffstat (limited to 'drivers/hid/hid-picolcd_lcd.c')
-rw-r--r--drivers/hid/hid-picolcd_lcd.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/hid/hid-picolcd_lcd.c b/drivers/hid/hid-picolcd_lcd.c
index 89821c2da6d7..22dcbe13da89 100644
--- a/drivers/hid/hid-picolcd_lcd.c
+++ b/drivers/hid/hid-picolcd_lcd.c
@@ -92,8 +92,7 @@ void picolcd_exit_lcd(struct picolcd_data *data)
struct lcd_device *ldev = data->lcd;
data->lcd = NULL;
- if (ldev)
- lcd_device_unregister(ldev);
+ lcd_device_unregister(ldev);
}
int picolcd_resume_lcd(struct picolcd_data *data)