diff options
| author | Gao Pan <pandy.gao@nxp.com> | 2016-01-08 13:33:15 +0800 |
|---|---|---|
| committer | Gao Pan <pandy.gao@nxp.com> | 2016-01-15 14:41:19 +0800 |
| commit | 081de8a91aa4987b79cf9938715d12dfb50b33bc (patch) | |
| tree | 82515c8031745320f1c68758598d783b6e392452 /drivers/i2c | |
| parent | 7914e062059f95fd54e2ce14571087e29f8b6ceb (diff) | |
i2c: imx: fix i2c resource leak with dma transfer
In i2c_imx_dma_xfer(), when dmaengine_submit() returns error,
the context goto label err_submit and then return. However, the
memory allocated for txdesc has not been freed yet, which
leads to resource leak.
(cherry picked from commit c55281531282930de0aace46b2d6b22653937818)
Signed-off-by: Gao Pan <b54642@freescale.com>
Signed-off-by: Fugang Duan <B38611@freescale.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-imx.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index 97dd038f1222..f1341a2371de 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -386,6 +386,7 @@ static int i2c_imx_dma_xfer(struct imx_i2c_struct *i2c_imx, return 0; err_submit: + dmaengine_terminate_all(dma->chan_using); err_desc: dma_unmap_single(chan_dev, dma->dma_buf, dma->dma_len, dma->dma_data_dir); |