summaryrefslogtreecommitdiff
path: root/drivers/iio
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2019-08-15 12:58:46 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-01-29 10:21:48 +0100
commit24cc265fd93c563add31130b8c40fb5733095aad (patch)
tree47e959c184e2b7d9c5d111549c6f53b080068ec5 /drivers/iio
parent7d05de194a7e2e57a710b966707819f1477a3392 (diff)
iio: dac: ad5380: fix incorrect assignment to val
[ Upstream commit b1e18768ef1214c0a8048327918a182cabe09f9d ] Currently the pointer val is being incorrectly incremented instead of the value pointed to by val. Fix this by adding in the missing * indirection operator. Addresses-Coverity: ("Unused value") Fixes: c03f2c536818 ("staging:iio:dac: Add AD5380 driver") Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/iio')
-rw-r--r--drivers/iio/dac/ad5380.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c
index 97d2c5111f43..8bf7fc626a9d 100644
--- a/drivers/iio/dac/ad5380.c
+++ b/drivers/iio/dac/ad5380.c
@@ -221,7 +221,7 @@ static int ad5380_read_raw(struct iio_dev *indio_dev,
if (ret)
return ret;
*val >>= chan->scan_type.shift;
- val -= (1 << chan->scan_type.realbits) / 2;
+ *val -= (1 << chan->scan_type.realbits) / 2;
return IIO_VAL_INT;
case IIO_CHAN_INFO_SCALE:
*val = 2 * st->vref;