summaryrefslogtreecommitdiff
path: root/drivers/md
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2017-09-06 14:25:51 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-09-27 11:00:16 +0200
commit093457f2bd329a2fdb253a68c4fffebb0e3d7786 (patch)
tree239026157c6bdfb2170b94dbad5a14e433f8e69b /drivers/md
parent5025da3b532bc5a16ca89670353aa1c89f33be29 (diff)
bcache: Fix leak of bdev reference
commit 4b758df21ee7081ab41448d21d60367efaa625b3 upstream. If blkdev_get_by_path() in register_bcache() fails, we try to lookup the block device using lookup_bdev() to detect which situation we are in to properly report error. However we never drop the reference returned to us from lookup_bdev(). Fix that. Signed-off-by: Jan Kara <jack@suse.cz> Acked-by: Coly Li <colyli@suse.de> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/md')
-rw-r--r--drivers/md/bcache/super.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 5bf9da324b78..46f4c7ee5560 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1960,6 +1960,8 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr,
else
err = "device busy";
mutex_unlock(&bch_register_lock);
+ if (!IS_ERR(bdev))
+ bdput(bdev);
if (attr == &ksysfs_register_quiet)
goto out;
}