diff options
| author | Laxman Dewangan <ldewangan@nvidia.com> | 2012-03-29 15:24:51 +0530 |
|---|---|---|
| committer | Simone Willett <swillett@nvidia.com> | 2012-04-03 09:35:50 -0700 |
| commit | b7ce7f54652d73d6fc1f787dfb4aeec3f475a17f (patch) | |
| tree | 24c37a2c463e57bb6b20fa2d9ba9f47e36ba64c4 /drivers/mfd | |
| parent | 314fcaf5342c1bec21d3d694a30ccdc3d60177cb (diff) | |
mfd: max8907c: Do not use I2C_M_NOSTART in first message
It is not recommended to use the flag I2C_M_NOSTART in first
message.
The documentation kernel/Documentation/i2c/i2c-proocol says:
Flag I2C_M_NOSTART:
In a combined transaction, no 'S Addr Wr/Rd [A]' is generated at some
point. For example, setting I2C_M_NOSTART on the second partial message
generates something like:
S Addr Rd [A] [Data] NA Data [A] P
If you set the I2C_M_NOSTART variable for the first partial message,
we do not generate Addr, but we do generate the startbit S. This will
probably confuse all other clients on your bus, so don't try this.
Change-Id: I8a8a4f6f91a1b53b6d443588ab18704cf100fd50
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Reviewed-on: http://git-master/r/93187
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
Tested-by: Bandi Krishna Chaitanya <bandik@nvidia.com>
Diffstat (limited to 'drivers/mfd')
| -rw-r--r-- | drivers/mfd/max8907c.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/max8907c.c b/drivers/mfd/max8907c.c index d03dbced21e1..ba85a0091642 100644 --- a/drivers/mfd/max8907c.c +++ b/drivers/mfd/max8907c.c @@ -26,7 +26,7 @@ static int max8907c_i2c_read(struct i2c_client *i2c, u8 reg, u8 count, u8 *dest) int ret = 0; xfer[0].addr = i2c->addr; - xfer[0].flags = I2C_M_NOSTART; + xfer[0].flags = 0; xfer[0].len = 1; xfer[0].buf = ® |