path: root/drivers/mtd
diff options
authorRoman Tereshonkov <>2011-11-29 12:49:18 +0200
committerGreg Kroah-Hartman <>2012-01-18 07:31:51 -0800
commitac3adf0e80a661573a25bbe589a6f7f2ad1d2529 (patch)
treeceb2139698bcf4aba6fddc61d2ae951fa117691e /drivers/mtd
parent93dad393c796013cb6371be63d7af600c5e36c2c (diff)
mtdoops: fix the oops_page_used array size
commit 556f063580db2953a7e53cd46b47724246320f60 upstream. The array of unsigned long pointed by oops_page_used is allocated by vmalloc which requires the size to be in bytes. BITS_PER_LONG is equal to 32. If we want to allocate memory for 32 pages with one bit per page then 32 / BITS_PER_LONG is equal to 1 byte that is 8 bits. To fix it we need to multiply the result by sizeof(unsigned long) equal to 4. Signed-off-by: Roman Tereshonkov <> Signed-off-by: Artem Bityutskiy <> Signed-off-by: David Woodhouse <> Signed-off-by: Greg Kroah-Hartman <>
Diffstat (limited to 'drivers/mtd')
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c
index e3e40f440323..02eeed3f9a41 100644
--- a/drivers/mtd/mtdoops.c
+++ b/drivers/mtd/mtdoops.c
@@ -369,7 +369,7 @@ static void mtdoops_notify_add(struct mtd_info *mtd)
/* oops_page_used is a bit field */
cxt->oops_page_used = vmalloc(DIV_ROUND_UP(mtdoops_pages,
+ BITS_PER_LONG) * sizeof(unsigned long));
if (!cxt->oops_page_used) {
printk(KERN_ERR "mtdoops: could not allocate page array\n");