summaryrefslogtreecommitdiff
path: root/drivers/staging/comedi/drivers/pcl726.c
diff options
context:
space:
mode:
authorH Hartley Sweeten <hsweeten@visionengravers.com>2014-08-25 15:23:48 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-08-30 13:20:50 -0700
commite24e9216ed9864e54704fb0bdc7e1868f9d61dc8 (patch)
treeb29f17f9984ecb6f8af91d1f8b610126ee7bdc26 /drivers/staging/comedi/drivers/pcl726.c
parent25e9398734ebc1ae10028d92ff001b45ce3da67f (diff)
staging: comedi: usbdux: remove deadcode in pcl726_intr_cmdtest()
Reported by: coverity Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/comedi/drivers/pcl726.c')
-rw-r--r--drivers/staging/comedi/drivers/pcl726.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/staging/comedi/drivers/pcl726.c b/drivers/staging/comedi/drivers/pcl726.c
index 74f6489bd124..8cb5efde4943 100644
--- a/drivers/staging/comedi/drivers/pcl726.c
+++ b/drivers/staging/comedi/drivers/pcl726.c
@@ -189,9 +189,6 @@ static int pcl726_intr_cmdtest(struct comedi_device *dev,
/* Step 2a : make sure trigger sources are unique */
/* Step 2b : and mutually compatible */
- if (err)
- return 2;
-
/* Step 3: check if arguments are trivially valid */
err |= cfc_check_trigger_arg_is(&cmd->start_arg, 0);
@@ -203,10 +200,9 @@ static int pcl726_intr_cmdtest(struct comedi_device *dev,
if (err)
return 3;
- /* step 4: ignored */
+ /* Step 4: fix up any arguments */
- if (err)
- return 4;
+ /* Step 5: check channel list if it exists */
return 0;
}