summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorJosef Bacik <josef@toxicpanda.com>2020-03-13 17:17:08 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-04-24 07:58:49 +0200
commitce216cff2d58b1fce51bb47b9a66666b8c21ed47 (patch)
treeedbc35da8ff74a7e3eee12fc9d23dab32b04bbdd /drivers
parentdaa2bddfcffacedf995c846427c88209e6f99023 (diff)
btrfs: track reloc roots based on their commit root bytenr
[ Upstream commit ea287ab157c2816bf12aad4cece41372f9d146b4 ] We always search the commit root of the extent tree for looking up back references, however we track the reloc roots based on their current bytenr. This is wrong, if we commit the transaction between relocating tree blocks we could end up in this code in build_backref_tree if (key.objectid == key.offset) { /* * Only root blocks of reloc trees use backref * pointing to itself. */ root = find_reloc_root(rc, cur->bytenr); ASSERT(root); cur->root = root; break; } find_reloc_root() is looking based on the bytenr we had in the commit root, but if we've COWed this reloc root we will not find that bytenr, and we will trip over the ASSERT(root). Fix this by using the commit_root->start bytenr for indexing the commit root. Then we change the __update_reloc_root() caller to be used when we switch the commit root for the reloc root during commit. This fixes the panic I was seeing when we started throttling relocation for delayed refs. Signed-off-by: Josef Bacik <josef@toxicpanda.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers')
0 files changed, 0 insertions, 0 deletions