diff options
| author | Pritesh Raithatha <praithatha@nvidia.com> | 2011-10-05 18:32:44 +0530 |
|---|---|---|
| committer | Varun Colbert <vcolbert@nvidia.com> | 2011-10-07 19:00:47 -0700 |
| commit | 256a97f67a52ae459e12022957bc0a6450c732ca (patch) | |
| tree | 4f9d4ab7ae041e331f7fcf975517261682baf8c3 /drivers | |
| parent | e3f703757c579cf836bb7f20df61284e39fee490 (diff) | |
power: bq27x00: safely exit if battery is not connected
-Driver is registering battery device even if battery is not
connected so moved powersupply init after battery detection.
Bug 872590
Change-Id: I7864ee357162a596d023af3bdbe17cfa8b9c390f
Signed-off-by: Pritesh Raithatha <praithatha@nvidia.com>
Reviewed-on: http://git-master/r/56220
Reviewed-by: Varun Colbert <vcolbert@nvidia.com>
Tested-by: Varun Colbert <vcolbert@nvidia.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/power/bq27x00_battery.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c index 2c493292faa9..7c84cf7ab5eb 100644 --- a/drivers/power/bq27x00_battery.c +++ b/drivers/power/bq27x00_battery.c @@ -757,21 +757,26 @@ static int bq27x00_battery_probe(struct i2c_client *client, di->bat.name = name; di->bus.read = &bq27x00_read_i2c; - if (bq27x00_powersupply_init(di)) - goto batt_failed_3; - i2c_set_clientdata(client, di); /* Let's see whether this adapter can support what we need. */ if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { dev_err(&client->dev, "insufficient functionality!\n"); - return -ENODEV; + retval = -ENODEV; + goto batt_failed_3; } read_data = i2c_smbus_read_word_data(di->client, BQ27x00_REG_FLAGS); - if (!(read_data & BQ27500_FLAG_BAT_DET)) + if (!(read_data & BQ27500_FLAG_BAT_DET)) { dev_err(&client->dev, "no battery present\n"); + retval = -ENODEV; + goto batt_failed_3; + } + + retval = bq27x00_powersupply_init(di); + if (retval < 0) + goto batt_failed_3; return 0; |