summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@gmail.com>2012-04-04 22:38:09 +0800
committerSimone Willett <swillett@nvidia.com>2012-06-03 08:08:48 -0700
commit37942f91eae17ea97ce20de7c3f74aac35a1120c (patch)
tree891ba2251ca1ee6b804ddba8da0cb012b23b1c90 /drivers
parent7380f01e1d2d665f8ffc7656320cb53475d84a24 (diff)
regulator: rc5t583: Fix off-by-one valid range checking for selector
The valid selector should be 0 ... nsteps-1. Signed-off-by: Axel Lin <axel.lin@gmail.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> (cherry picked from commit 9cc7a453b637d8c1f628f9873204ff55d7aa664c) Change-Id: Ie1a39883036de3b2945d35854e0a16c46d2a9db2 Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> Reviewed-on: http://git-master/r/105882 Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Bitan Biswas <bbiswas@nvidia.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/regulator/rc5t583-regulator.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/regulator/rc5t583-regulator.c b/drivers/regulator/rc5t583-regulator.c
index c2c543c3a278..48437ff853ca 100644
--- a/drivers/regulator/rc5t583-regulator.c
+++ b/drivers/regulator/rc5t583-regulator.c
@@ -131,7 +131,7 @@ static int rc5t583_set_voltage_sel(struct regulator_dev *rdev,
struct rc5t583_regulator *reg = rdev_get_drvdata(rdev);
struct rc5t583_regulator_info *ri = reg->reg_info;
int ret;
- if (selector > ri->nsteps) {
+ if (selector >= ri->nsteps) {
dev_err(&rdev->dev, "Invalid selector 0x%02x\n", selector);
return -EINVAL;
}