summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorXiaohui Tao <xtao@nvidia.com>2013-08-20 10:38:52 -0700
committerGabby Lee <galee@nvidia.com>2013-08-20 20:22:07 -0700
commit949749fdd3be199823c188a8993016bd63ab12e6 (patch)
tree36342d200a70dbe9c4c982a1019dea75ec2a037a /drivers
parent935daea80d24f621a9328642d025762af26ffb55 (diff)
input: misc: mpu: change self test criteria
1) Increasing the at rest (Test #3) Threshold from 10dps to 40dps Invensense claims this was a programming error from their side and was updated in their code base over a year ago. They say all their customers are using (or should be) using the new code (with the relaxed threshold). 2) Increasing the ST compare (Test #1) Threshold from 14% to 50% Their response was 14% was set based on their factory results. However, over time, they had several customer investigations and found that their customer environments are a lot nosier than their factory. Based on more collected samples from the customer site, they increased this limit from 14% to 50%. They claim a major tablet manufacturer with 100.s of thousands of units has taken the new 50% threshold over a year ago and currently no reported test escapes with the new threshold. Bug 1343976 Change-Id: I684f186134db3717d4d1304c14f97dd310843cab Signed-off-by: Xiaohui Tao <xtao@nvidia.com> Reviewed-on: http://git-master/r/263972 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: Robert Collins <rcollins@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Gabby Lee <galee@nvidia.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/input/misc/mpu/inv_gyro_misc.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/input/misc/mpu/inv_gyro_misc.c b/drivers/input/misc/mpu/inv_gyro_misc.c
index 53aaebb9f32b..bfdb6ed064b7 100644
--- a/drivers/input/misc/mpu/inv_gyro_misc.c
+++ b/drivers/input/misc/mpu/inv_gyro_misc.c
@@ -70,8 +70,8 @@
#define DEF_ACCEL_ST_SHIFT_MIN (300)
#define DEF_ACCEL_ST_SHIFT_MAX (950)
-#define DEF_ACCEL_ST_SHIFT_DELTA (140)
-#define DEF_GYRO_CT_SHIFT_DELTA (140)
+#define DEF_ACCEL_ST_SHIFT_DELTA (500)
+#define DEF_GYRO_CT_SHIFT_DELTA (500)
/* gyroscope Coriolis self test min and max bias shift (dps) */
#define DEF_GYRO_CT_SHIFT_MIN (10)
#define DEF_GYRO_CT_SHIFT_MAX (105)
@@ -642,7 +642,7 @@ static int inv_check_6050_gyro_self_test(struct inv_gyro_state_s *st,
}
}
for (i = 0; i < 3; i++) {
- if (abs(reg_avg[i])*4 > 20*2*1000*131)
+ if (abs(reg_avg[i]) > 20*2*1000*131)
ret_val |= (1<<i);
}
return ret_val;