diff options
| author | Preston Fick <preston.fick@silabs.com> | 2014-07-16 14:31:30 -0500 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-09-02 11:22:42 +0200 |
| commit | 664dc48e6aaa67b14a4742d1bf77bde15b1603e6 (patch) | |
| tree | eb04e5a79b3ba3381d8687bcc58c0bb109357352 /drivers | |
| parent | bd78518ba277b4f768941f80c5e7b6f0c3c8ccf5 (diff) | |
USB: serial: cp210x: Removing unncessary `usb_reset_device` on startup
commit 934ef5aca9daea10507eebcbd0fb8f6d57d55359 upstream.
This `usb_reset_device` command has been around since the driver was
originally reverse engineered. It doesn't cause much issue on single
interface CP210x devices, but on the CP2105 and CP2108 with 2 and 4
interfaces respectively it will cause instability on enumeration and
delays enumeration noticably. There should be no reason to reset a device
at startup, per the CP210x AN571 spec.
Signed-off-by: Preston Fick <preston.fick@silabs.com>
Cc: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/serial/cp210x.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index 1db213a6e843..e5ac744ac73f 100644 --- a/drivers/usb/serial/cp210x.c +++ b/drivers/usb/serial/cp210x.c @@ -860,9 +860,6 @@ static int cp210x_startup(struct usb_serial *serial) struct usb_host_interface *cur_altsetting; struct cp210x_serial_private *spriv; - /* cp210x buffers behave strangely unless device is reset */ - usb_reset_device(serial->dev); - spriv = kzalloc(sizeof(*spriv), GFP_KERNEL); if (!spriv) return -ENOMEM; |