diff options
| author | Andrew Morton <akpm@linux-foundation.org> | 2008-04-28 02:16:30 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-08-06 10:11:01 -0700 |
| commit | bc4e51023d592becd9e582923b35d3bfd7211dc7 (patch) | |
| tree | 61d61b2377170135487d425034f328153e40d80b /fs | |
| parent | e6eabbc07825ed69c0b07e3c986b656eb85bcc0c (diff) | |
FAT_VALID_MEDIA(): remove pointless test
commit 73f20e58b1d586e9f6d3ddc3aad872829aca7743 upstream
The on-disk media specification field in FAT is only 8-bits, so testing for
<=0xff is pointless, and can generate a "comparison is always true due to
limited range of data type" warning.
While we're there, convert FAT_VALID_MEDIA() into a C function - the present
implementation is buggy: it generates either one or two references to its
argument.
Cc: Frank Seidel <fseidel@suse.de>
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/fat/inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 53f3cf62b7c1..98f0e874c5e1 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -1208,7 +1208,7 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, */ media = b->media; - if (!FAT_VALID_MEDIA(media)) { + if (!fat_valid_media(media)) { if (!silent) printk(KERN_ERR "FAT: invalid media value (0x%02x)\n", media); |