diff options
| author | Steven Whitehouse <swhiteho@redhat.com> | 2013-11-21 18:47:57 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-12-04 11:06:16 -0800 |
| commit | 8a562a6e21356a0787f1c87e385a425b7264661d (patch) | |
| tree | 228132d8dfd82e867233f21111b5035a0d8bcd6c /fs | |
| parent | be5e7f1a9a1f8baadce3a7ac637a3dcbd1491a10 (diff) | |
GFS2: Fix ref count bug relating to atomic_open
commit ea0341e071527d5cec350917b01ab901af09d758 upstream.
In the case that atomic_open calls finish_no_open() with
the dentry that was supplied to gfs2_atomic_open() an
extra reference count is required. This patch fixes that
issue preventing a bug trap triggering at umount time.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/gfs2/inode.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 968d4c56e5eb..12987666e5f0 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c @@ -1168,8 +1168,11 @@ static int gfs2_atomic_open(struct inode *dir, struct dentry *dentry, if (d != NULL) dentry = d; if (dentry->d_inode) { - if (!(*opened & FILE_OPENED)) + if (!(*opened & FILE_OPENED)) { + if (d == NULL) + dget(dentry); return finish_no_open(file, dentry); + } dput(d); return 0; } |