diff options
| author | Darrick J. Wong <darrick.wong@oracle.com> | 2016-08-03 10:58:53 +1000 |
|---|---|---|
| committer | Sasha Levin <alexander.levin@verizon.com> | 2017-07-26 19:25:36 -0400 |
| commit | 49607e63920b852bf158e41e361fd074e17e0e1c (patch) | |
| tree | 708ae5657459e92693f1a75fd1e6a592728de036 /fs | |
| parent | 2ac51e21d8c50ca37fc9b5b9a9b4937c810b0d0a (diff) | |
xfs: in _attrlist_by_handle, copy the cursor back to userspace
[ Upstream commit 0facef7fb053be4353c0a48c2f48c9dbee91cb19 ]
When we're iterating inode xattrs by handle, we have to copy the
cursor back to userspace so that a subsequent invocation actually
retrieves subsequent contents.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/xfs/xfs_ioctl.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index e69a0899bc05..3b7985991823 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c @@ -402,6 +402,7 @@ xfs_attrlist_by_handle( { int error = -ENOMEM; attrlist_cursor_kern_t *cursor; + struct xfs_fsop_attrlist_handlereq __user *p = arg; xfs_fsop_attrlist_handlereq_t al_hreq; struct dentry *dentry; char *kbuf; @@ -434,6 +435,11 @@ xfs_attrlist_by_handle( if (error) goto out_kfree; + if (copy_to_user(&p->pos, cursor, sizeof(attrlist_cursor_kern_t))) { + error = -EFAULT; + goto out_kfree; + } + if (copy_to_user(al_hreq.buffer, kbuf, al_hreq.buflen)) error = -EFAULT; |