path: root/fs
diff options
authorXi Wang <>2011-12-12 21:55:52 +0000
committerGreg Kroah-Hartman <>2012-01-12 11:33:47 -0800
commit723bf827f6d066a119f202131130af431dcc41a2 (patch)
treef15e5156a7bc82dde5d453dd994899c9dee6ca0f /fs
parent1820b28c96690ab8bc8977089d8eb4a9e7128117 (diff)
xfs: fix acl count validation in xfs_acl_from_disk()
commit 093019cf1b18dd31b2c3b77acce4e000e2cbc9ce upstream. Commit fa8b18ed didn't prevent the integer overflow and possible memory corruption. "count" can go negative and bypass the check. Signed-off-by: Xi Wang <> Reviewed-by: Christoph Hellwig <> Signed-off-by: Ben Myers <> Signed-off-by: Greg Kroah-Hartman <>
Diffstat (limited to 'fs')
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs_acl.c
index 76e4266d2e7e..ac702a6eab9b 100644
--- a/fs/xfs/xfs_acl.c
+++ b/fs/xfs/xfs_acl.c
@@ -39,7 +39,7 @@ xfs_acl_from_disk(struct xfs_acl *aclp)
struct posix_acl_entry *acl_e;
struct posix_acl *acl;
struct xfs_acl_entry *ace;
- int count, i;
+ unsigned int count, i;
count = be32_to_cpu(aclp->acl_cnt);
if (count > XFS_ACL_MAX_ENTRIES)