diff options
| author | Changli Gao <xiaosuo@gmail.com> | 2010-06-29 13:10:36 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-08-02 10:30:07 -0700 |
| commit | 73759b079bcc5f30d357cf78e10dd3506371a830 (patch) | |
| tree | 7a59fad805041611b3d1c5e636f73818c71fb35c /fs | |
| parent | f2df0ea492e2c5ce9c71d8d261522d817986d269 (diff) | |
splice: check f_mode for seekable file
commit 19c9a49b432f245c6293508d164a4350f1f2c601 upstream.
check f_mode for seekable file
As a seekable file is allowed without a llseek function, so the old way isn't
work any more.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/splice.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/splice.c b/fs/splice.c index 5be13449150e..eb602cbc1eb5 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -1322,8 +1322,7 @@ static long do_splice(struct file *in, loff_t __user *off_in, if (off_in) return -ESPIPE; if (off_out) { - if (!out->f_op || !out->f_op->llseek || - out->f_op->llseek == no_llseek) + if (!(out->f_mode & FMODE_PWRITE)) return -EINVAL; if (copy_from_user(&offset, off_out, sizeof(loff_t))) return -EFAULT; @@ -1343,8 +1342,7 @@ static long do_splice(struct file *in, loff_t __user *off_in, if (off_out) return -ESPIPE; if (off_in) { - if (!in->f_op || !in->f_op->llseek || - in->f_op->llseek == no_llseek) + if (!(in->f_mode & FMODE_PREAD)) return -EINVAL; if (copy_from_user(&offset, off_in, sizeof(loff_t))) return -EFAULT; |