diff options
| author | Yanchuan Nian <ycnian@gmail.com> | 2013-01-04 20:19:49 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-01-11 09:18:38 -0800 |
| commit | 0b7d74eb80d06be3b5792cbdd2c77d1ccb05cc4b (patch) | |
| tree | 14fd97d159f7b948b5e63b7a8d86c34d03a31c21 /fs | |
| parent | 5865afd9e73a8981f38344ddcb42d9f2049c1469 (diff) | |
pnfs: Increase the refcount when LAYOUTGET fails the first time
commit 39e88fcfb1d5c6c4b1ff76ca2ab76cf449b850e8 upstream.
The layout will be set unusable if LAYOUTGET fails. Is it reasonable to
increase the refcount iff LAYOUTGET fails the first time?
Signed-off-by: Yanchuan Nian <ycnian@gmail.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/nfs/pnfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c index 2878f97bd78d..b7f7538a4c9c 100644 --- a/fs/nfs/pnfs.c +++ b/fs/nfs/pnfs.c @@ -254,7 +254,7 @@ static void pnfs_layout_set_fail_bit(struct pnfs_layout_hdr *lo, int fail_bit) { lo->plh_retry_timestamp = jiffies; - if (test_and_set_bit(fail_bit, &lo->plh_flags)) + if (!test_and_set_bit(fail_bit, &lo->plh_flags)) atomic_inc(&lo->plh_refcount); } |