diff options
| author | Miklos Szeredi <mszeredi@suse.cz> | 2013-09-16 14:51:59 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-10-01 09:40:58 -0700 |
| commit | 03c58b665fd0ce5f0acc6ebcd3c3a0df586e05d3 (patch) | |
| tree | 9b6ee9735d51e0e657ad355e41fe77854af2d092 /fs | |
| parent | 157c2c2d4500977dc280901dbbdf6edcf1613965 (diff) | |
cifs: fix filp leak in cifs_atomic_open()
commit dfb1d61b0e9f9e2c542e9adc8d970689f4114ff6 upstream.
If an error occurs after having called finish_open() then fput() needs to
be called on the already opened file.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Cc: Steve French <sfrench@samba.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/dir.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index d62ce0d48141..4c019f471ab7 100644 --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c @@ -499,6 +499,7 @@ cifs_atomic_open(struct inode *inode, struct dentry *direntry, if (server->ops->close) server->ops->close(xid, tcon, &fid); cifs_del_pending_open(&open); + fput(file); rc = -ENOMEM; } |