diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2013-05-01 23:42:47 -0400 |
|---|---|---|
| committer | Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2013-07-05 18:56:36 +0300 |
| commit | b3743d58728192f99767c272371a1d80f974537a (patch) | |
| tree | ceb05a1a9e28c7f0ab21f2d3651bd1564d793734 /include | |
| parent | f08cdd4be3bf5ae2620716ed7779c56900ba30eb (diff) | |
UBI: document UBI_IOCVOLUP better in user header
The current ioctl define implies that this func expects to be passed a
64bit number directly rather than a pointer to a 64bit. The code that
processes this ioctl shows that it clearly expects a pointer.
It'd be best if we could change the type to "__s64*", but that would
change the generated ioctl number thus breaking the userland ABI. So
just add a comment for intrepid developers.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/mtd/ubi-user.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h index 53cae1e11e57..723c324590c1 100644 --- a/include/mtd/ubi-user.h +++ b/include/mtd/ubi-user.h @@ -173,7 +173,10 @@ #define UBI_VOL_IOC_MAGIC 'O' -/* Start UBI volume update */ +/* Start UBI volume update + * Note: This actually takes a pointer (__s64*), but we can't change + * that without breaking the ABI on 32bit systems + */ #define UBI_IOCVOLUP _IOW(UBI_VOL_IOC_MAGIC, 0, __s64) /* LEB erasure command, used for debugging, disabled by default */ #define UBI_IOCEBER _IOW(UBI_VOL_IOC_MAGIC, 1, __s32) |