summaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorTommi Rantala <tt.rantala@gmail.com>2013-04-13 22:49:14 +0300
committerBen Hutchings <ben@decadent.org.uk>2013-05-13 15:02:32 +0100
commit3fc8fc1cc2d585c1f695f7de914063258aafe50e (patch)
tree1eb3b02ffede14a177b80c204c3de011768cf7ea /kernel
parent4221c304a05e4279d9f378519e81c6c69bc6fc4d (diff)
perf: Treat attr.config as u64 in perf_swevent_init()
commit 8176cced706b5e5d15887584150764894e94e02f upstream. Trinity discovered that we fail to check all 64 bits of attr.config passed by user space, resulting to out-of-bounds access of the perf_swevent_enabled array in sw_perf_event_destroy(). Introduced in commit b0a873ebb ("perf: Register PMU implementations"). Signed-off-by: Tommi Rantala <tt.rantala@gmail.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: davej@redhat.com Cc: Paul Mackerras <paulus@samba.org> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> Link: http://lkml.kernel.org/r/1365882554-30259-1-git-send-email-tt.rantala@gmail.com Signed-off-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/events/core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/events/core.c b/kernel/events/core.c
index d23dfa713ec0..9f219156ba3c 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -5164,7 +5164,7 @@ static void sw_perf_event_destroy(struct perf_event *event)
static int perf_swevent_init(struct perf_event *event)
{
- int event_id = event->attr.config;
+ u64 event_id = event->attr.config;
if (event->attr.type != PERF_TYPE_SOFTWARE)
return -ENOENT;