diff options
| author | Sasha Levin <sasha.levin@oracle.com> | 2014-12-03 19:22:48 -0500 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2015-02-20 00:49:34 +0000 |
| commit | 1751fde0bb621f9d05dc76c7a0045b70b88918c2 (patch) | |
| tree | 75a72707a206e6c691cd2ce4652f019ea24d1432 /kernel | |
| parent | ee368a2c5ed1806a6cbdcddadac86cbb3816d2f5 (diff) | |
time: settimeofday: Validate the values of tv from user
commit 6ada1fc0e1c4775de0e043e1bd3ae9d065491aa5 upstream.
An unvalidated user input is multiplied by a constant, which can result in
an undefined behaviour for large values. While this is validated later,
we should avoid triggering undefined behaviour.
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
[jstultz: include trivial milisecond->microsecond correction noticed
by Andy]
Signed-off-by: John Stultz <john.stultz@linaro.org>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/time.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/kernel/time.c b/kernel/time.c index 060f9611c8be..f64e88bd5444 100644 --- a/kernel/time.c +++ b/kernel/time.c @@ -192,6 +192,10 @@ SYSCALL_DEFINE2(settimeofday, struct timeval __user *, tv, if (tv) { if (copy_from_user(&user_tv, tv, sizeof(*tv))) return -EFAULT; + + if (!timeval_valid(&user_tv)) + return -EINVAL; + new_ts.tv_sec = user_tv.tv_sec; new_ts.tv_nsec = user_tv.tv_usec * NSEC_PER_USEC; } |