diff options
| author | Dima Zavin <dima@android.com> | 2010-09-28 17:35:31 -0700 |
|---|---|---|
| committer | Brian Swetland <swetland@google.com> | 2011-03-29 13:57:58 -0700 |
| commit | ae0429e84759446975ea243a99d6ba0803b6428f (patch) | |
| tree | 9855d078c11537a9aa654b2553d7b9f2199de130 /kernel | |
| parent | 9546f279dd8951603822fa248a579cb07065bf3e (diff) | |
sched: use the old min_vruntime when normalizing on dequeue
After pulling the thread off the run-queue during a cgroup change,
the cfs_rq.min_vruntime gets recalculated. The dequeued thread's vruntime
then gets normalized to this new value. This can then lead to the thread
getting an unfair boost in the new group if the vruntime of the next
task in the old run-queue was way further ahead.
Cc: Arve Hjønnevåg <arve@android.com>
Signed-off-by: Dima Zavin <dima@android.com>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/sched_fair.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c index 0c26e2df450e..8faa29ac949f 100644 --- a/kernel/sched_fair.c +++ b/kernel/sched_fair.c @@ -1014,6 +1014,8 @@ static void clear_buddies(struct cfs_rq *cfs_rq, struct sched_entity *se) static void dequeue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags) { + u64 min_vruntime; + /* * Update run-time statistics of the 'current'. */ @@ -1040,6 +1042,8 @@ dequeue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags) se->on_rq = 0; update_cfs_load(cfs_rq, 0); account_entity_dequeue(cfs_rq, se); + + min_vruntime = cfs_rq->min_vruntime; update_min_vruntime(cfs_rq); update_cfs_shares(cfs_rq, 0); @@ -1049,7 +1053,7 @@ dequeue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags) * movement in our normalized position. */ if (!(flags & DEQUEUE_SLEEP)) - se->vruntime -= cfs_rq->min_vruntime; + se->vruntime -= min_vruntime; } /* |