summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorMichal Schmidt <mschmidt@redhat.com>2014-06-02 18:25:02 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-06-26 15:15:38 -0400
commit1ab214eb6e840d3a4a1165a6978cff2448f97739 (patch)
tree79f81a3cded49e27b84e6855a8f0dfde4b9e042f /lib
parenta81347b883e3150b0cbabdb1a8e6c5d5120f80fb (diff)
netlink: rate-limit leftover bytes warning and print process name
[ Upstream commit bfc5184b69cf9eeb286137640351c650c27f118a ] Any process is able to send netlink messages with leftover bytes. Make the warning rate-limited to prevent too much log spam. The warning is supposed to help find userspace bugs, so print the triggering command name to implicate the buggy program. [v2: Use pr_warn_ratelimited instead of printk_ratelimited.] Signed-off-by: Michal Schmidt <mschmidt@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib')
-rw-r--r--lib/nlattr.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/nlattr.c b/lib/nlattr.c
index fc6754720ced..10ad042d01be 100644
--- a/lib/nlattr.c
+++ b/lib/nlattr.c
@@ -201,8 +201,8 @@ int nla_parse(struct nlattr **tb, int maxtype, const struct nlattr *head,
}
if (unlikely(rem > 0))
- printk(KERN_WARNING "netlink: %d bytes leftover after parsing "
- "attributes.\n", rem);
+ pr_warn_ratelimited("netlink: %d bytes leftover after parsing attributes in process `%s'.\n",
+ rem, current->comm);
err = 0;
errout: