path: root/mm
diff options
authorFrantisek Hrbata <>2011-12-19 17:11:59 -0800
committerRohan Somvanshi <>2012-01-11 09:29:32 -0800
commitb42e9d1709655fb4fcea049f1766122b8cf3c6cb (patch)
treef8b5b49db350a331345bbfc75efa6e0f61dee37b /mm
parentc3b50f5523309f711d0f10c1ba518d5a0aafdd65 (diff)
oom: fix integer overflow of points in oom_badness
commit ff05b6f7ae762b6eb464183eec994b28ea09f6dd upstream. An integer overflow will happen on 64bit archs if task's sum of rss, swapents and nr_ptes exceeds (2^31)/1000 value. This was introduced by commit f755a04 oom: use pte pages in OOM score where the oom score computation was divided into several steps and it's no longer computed as one expression in unsigned long(rss, swapents, nr_pte are unsigned long), where the result value assigned to points(int) is in range(1..1000). So there could be an int overflow while computing 176 points *= 1000; and points may have negative value. Meaning the oom score for a mem hog task will be one. 196 if (points <= 0) 197 return 1; For example: [ 3366] 0 3366 35390480 24303939 5 0 0 oom01 Out of memory: Kill process 3366 (oom01) score 1 or sacrifice child Here the oom1 process consumes more than 24303939(rss)*4096~=92GB physical memory, but it's oom score is one. In this situation the mem hog task is skipped and oom killer kills another and most probably innocent task with oom score greater than one. The points variable should be of type long instead of int to prevent the int overflow. Signed-off-by: Frantisek Hrbata <> Acked-by: KOSAKI Motohiro <> Acked-by: Oleg Nesterov <> Acked-by: David Rientjes <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <> Signed-off-by: Greg Kroah-Hartman <> Change-Id: I56c6a8a4aadca809e04276eabe5552935c51387f Reviewed-on: http://git-master/r/74176 Reviewed-by: Varun Wadekar <> Tested-by: Varun Wadekar <>
Diffstat (limited to 'mm')
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 626303b52f3c..e9a17857a203 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -162,7 +162,7 @@ static bool oom_unkillable_task(struct task_struct *p,
unsigned int oom_badness(struct task_struct *p, struct mem_cgroup *mem,
const nodemask_t *nodemask, unsigned long totalpages)
- int points;
+ long points;
if (oom_unkillable_task(p, mem, nodemask))
return 0;