path: root/mm
diff options
authorMichel Lespinasse <>2011-12-19 17:12:06 -0800
committerRohan Somvanshi <>2012-01-11 09:29:06 -0800
commitc3b50f5523309f711d0f10c1ba518d5a0aafdd65 (patch)
tree04d9a9bbd746097b345c50d674ecb64de86a38bb /mm
parent2976f8a85459c5a088171b9792292c2eab2d9147 (diff)
binary_sysctl(): fix memory leak
commit 3d3c8f93a237b64580c5c5e138edeb1377e98230 upstream. binary_sysctl() calls sysctl_getname() which allocates from names_cache slab usin __getname() The matching function to free the name is __putname(), and not putname() which should be used only to match getname() allocations. This is because when auditing is enabled, putname() calls audit_putname *instead* (not in addition) to __putname(). Then, if a syscall is in progress, audit_putname does not release the name - instead, it expects the name to get released when the syscall completes, but that will happen only if audit_getname() was called previously, i.e. if the name was allocated with getname() rather than the naked __getname(). So, __getname() followed by putname() ends up leaking memory. Signed-off-by: Michel Lespinasse <> Acked-by: Al Viro <> Cc: Christoph Hellwig <> Cc: Eric Paris <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <> Signed-off-by: Greg Kroah-Hartman <> Change-Id: Ia6c066b0703eeafc61eafdd5addf157ee671bd68 Reviewed-on: http://git-master/r/74175 Reviewed-by: Varun Wadekar <> Tested-by: Varun Wadekar <>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions