summaryrefslogtreecommitdiff
path: root/net/9p
diff options
context:
space:
mode:
authorGertjan Halkes <gertjan@google.com>2018-09-05 15:41:29 +0900
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-04-20 09:15:04 +0200
commitfdf0c593ec3e7924952f195933f676e53b319302 (patch)
tree6eac053123fd38155410b4370bdbbb3d06dc0a0c /net/9p
parentad78e2e057ab8d914a2b5e3e6acf29c3c8a428a3 (diff)
9p: do not trust pdu content for stat item size
[ Upstream commit 2803cf4379ed252894f046cb8812a48db35294e3 ] v9fs_dir_readdir() could deadloop if a struct was sent with a size set to -2 Link: http://lkml.kernel.org/r/1536134432-11997-1-git-send-email-asmadeus@codewreck.org Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=88021 Signed-off-by: Gertjan Halkes <gertjan@google.com> Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net/9p')
-rw-r--r--net/9p/protocol.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/net/9p/protocol.c b/net/9p/protocol.c
index 9743837aebc6..766d1ef4640a 100644
--- a/net/9p/protocol.c
+++ b/net/9p/protocol.c
@@ -570,9 +570,10 @@ int p9stat_read(struct p9_client *clnt, char *buf, int len, struct p9_wstat *st)
if (ret) {
p9_debug(P9_DEBUG_9P, "<<< p9stat_read failed: %d\n", ret);
trace_9p_protocol_dump(clnt, &fake_pdu);
+ return ret;
}
- return ret;
+ return fake_pdu.offset;
}
EXPORT_SYMBOL(p9stat_read);