summaryrefslogtreecommitdiff
path: root/net/ipv6
diff options
context:
space:
mode:
authorSasha Levin <sashal@kernel.org>2018-10-31 11:06:10 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-11-10 07:42:57 -0800
commit2edec22d18758c9b29301ded2291f051d65422e9 (patch)
treef53774d3be772eb67f10f80b31d06e1670ea63eb /net/ipv6
parent31e29bafe9148f0e509119e826b7f453055bcbb0 (diff)
Revert "netfilter: ipv6: nf_defrag: drop skb dst before queueing"
This reverts commit ad8b1ffc3efae2f65080bdb11145c87d299b8f9a. From Florian Westphal <fw@strlen.de>: It causes kernel crash for locally generated ipv6 fragments when netfilter ipv6 defragmentation is used. The faulty commit is not essential for -stable, it only delays netns teardown for longer than needed when that netns still has ipv6 frags queued. Much better than crash :-/ Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net/ipv6')
-rw-r--r--net/ipv6/netfilter/nf_conntrack_reasm.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c
index b9147558a8f2..e46185377981 100644
--- a/net/ipv6/netfilter/nf_conntrack_reasm.c
+++ b/net/ipv6/netfilter/nf_conntrack_reasm.c
@@ -597,8 +597,6 @@ int nf_ct_frag6_gather(struct net *net, struct sk_buff *skb, u32 user)
fq->q.meat == fq->q.len &&
nf_ct_frag6_reasm(fq, skb, dev))
ret = 0;
- else
- skb_dst_drop(skb);
out_unlock:
spin_unlock_bh(&fq->q.lock);