diff options
| author | JP Abgrall <jpa@google.com> | 2011-07-06 12:05:49 -0700 |
|---|---|---|
| committer | Dan Willemsen <dwillemsen@nvidia.com> | 2011-11-30 21:38:46 -0800 |
| commit | 74e8c2f4cd74e0aec29704db573929eabbd93196 (patch) | |
| tree | 1956f96c9f6f972e48dfc55ba9ce6d3631db9ee7 /net/netfilter | |
| parent | f67ccbde17e5b0fc1b6bba749b07e60d0605d98d (diff) | |
netfilter: qtaguid: fix bad-arg handling when tagging socket
When processing args passed to the procfs ctrl, if the tag was
invalid it would exit without releasing the spin_lock...
Bye bye scheduling.
Signed-off-by: JP Abgrall <jpa@google.com>
Change-Id: Ic1480ae9d37bba687586094cf6d0274db9c5b28a
Diffstat (limited to 'net/netfilter')
| -rw-r--r-- | net/netfilter/xt_qtaguid.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/xt_qtaguid.c b/net/netfilter/xt_qtaguid.c index 3b5ab3ff0615..3cacec07fbf7 100644 --- a/net/netfilter/xt_qtaguid.c +++ b/net/netfilter/xt_qtaguid.c @@ -1065,7 +1065,7 @@ static int qtaguid_ctrl_parse(const char *input, int count) goto ok; err_unlock: - if (!sock_tag_entry) + if (sock_tag_entry) spin_unlock_irqrestore(&sock_tag_list_lock, flags); err: ok: |