diff options
| author | Daniel Borkmann <dborkman@redhat.com> | 2013-02-08 03:04:34 +0000 |
|---|---|---|
| committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2014-02-10 16:10:51 -0500 |
| commit | 051c3342813e7bda856fc43534e29c9023c648fc (patch) | |
| tree | a3dcffc93c991ec7a138497ab8d9af96ae386893 /net | |
| parent | f85a52045dda90826bbb59b6b68f6332529eadab (diff) | |
net: sctp: sctp_setsockopt_auth_key: use kzfree instead of kfree
commit 6ba542a291a5e558603ac51cda9bded347ce7627 upstream.
In sctp_setsockopt_auth_key, we create a temporary copy of the user
passed shared auth key for the endpoint or association and after
internal setup, we free it right away. Since it's sensitive data, we
should zero out the key before returning the memory back to the
allocator. Thus, use kzfree instead of kfree, just as we do in
sctp_auth_key_put().
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sctp/socket.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 03daceb2d9a0..38c19d38f438 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -3276,7 +3276,7 @@ static int sctp_setsockopt_auth_key(struct sock *sk, ret = sctp_auth_set_key(sctp_sk(sk)->ep, asoc, authkey); out: - kfree(authkey); + kzfree(authkey); return ret; } |