diff options
| author | Stefan Assmann <sassmann@kpanic.de> | 2020-08-13 13:26:38 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-10-10 21:46:41 +0200 |
| commit | d037d8964fb86c492df5f669b88a8b93df056639 (patch) | |
| tree | a09aed143bbd8f6d1cb32bfaf19df02e0421b177 /security | |
| parent | 2d78e2d3e31f64fb8c2a01bf82149694beb27422 (diff) | |
i40e: fix return of uninitialized aq_ret in i40e_set_vsi_promisc
[ Upstream commit e1e1b5356eb48dce4307f5cae10e4d6d5bd3df74 ]
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c: In function ‘i40e_set_vsi_promisc’:
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:1176:14: error: ‘aq_ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
i40e_status aq_ret;
In case the code inside the if statement and the for loop does not get
executed aq_ret will be uninitialized when the variable gets returned at
the end of the function.
Avoid this by changing num_vlans from int to u16, so aq_ret always gets
set. Making this change in additional places as num_vlans should never
be negative.
Fixes: 37d318d7805f ("i40e: Remove scheduling while atomic possibility")
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions