diff options
| author | Xin Xiong <xiongx18@fudan.edu.cn> | 2022-04-28 11:39:08 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-08-25 11:18:21 +0200 |
| commit | ef6fb6f0d0d8440595b45a7e53c6162c737177f4 (patch) | |
| tree | df8a0cebc79b994b08d40230374da8d6a006bb59 /security | |
| parent | 7f6092dc8f7a0892acf08f2956d8b7d9c267e5de (diff) | |
apparmor: fix reference count leak in aa_pivotroot()
commit 11c3627ec6b56c1525013f336f41b79a983b4d46 upstream.
The aa_pivotroot() function has a reference counting bug in a specific
path. When aa_replace_current_label() returns on success, the function
forgets to decrement the reference count of “target”, which is
increased earlier by build_pivotroot(), causing a reference leak.
Fix it by decreasing the refcount of “target” in that path.
Fixes: 2ea3ffb7782a ("apparmor: add mount mediation")
Co-developed-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Co-developed-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'security')
| -rw-r--r-- | security/apparmor/mount.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/security/apparmor/mount.c b/security/apparmor/mount.c index 7c8e6d748306..4b433cf1526f 100644 --- a/security/apparmor/mount.c +++ b/security/apparmor/mount.c @@ -683,6 +683,7 @@ int aa_pivotroot(struct aa_label *label, const struct path *old_path, aa_put_label(target); goto out; } + aa_put_label(target); } else /* already audited error */ error = PTR_ERR(target); |