diff options
| author | Florin Malita <fmalita@gmail.com> | 2006-10-16 14:43:43 +0200 |
|---|---|---|
| committer | Chris Wright <chrisw@sous-sol.org> | 2006-11-03 17:33:45 -0800 |
| commit | e0cd3e38de139be4929fe8b18d85da585580420b (patch) | |
| tree | 3497a1987680424730e9ecfd5d063c0763bbf5d3 /sound | |
| parent | 0136d6eaf1356d5c484e84664f7688de895daaf6 (diff) | |
[PATCH] ALSA: Dereference after free in snd_hwdep_release()
snd_card_file_remove() may free hw->card so we can't dereference
hw->card->module after that.
Coverity ID 1420.
This bug actually causes an Oops at usb-disconnection, especially
with CONFIG_PREEMPT.
From: Florin Malita <fmalita@gmail.com>
Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/core/hwdep.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c index 8bd0dcc93eba..a562f96f3010 100644 --- a/sound/core/hwdep.c +++ b/sound/core/hwdep.c @@ -158,6 +158,7 @@ static int snd_hwdep_release(struct inode *inode, struct file * file) { int err = -ENXIO; struct snd_hwdep *hw = file->private_data; + struct module *mod = hw->card->module; mutex_lock(&hw->open_mutex); if (hw->ops.release) { err = hw->ops.release(hw, file); @@ -167,7 +168,7 @@ static int snd_hwdep_release(struct inode *inode, struct file * file) hw->used--; snd_card_file_remove(hw->card, file); mutex_unlock(&hw->open_mutex); - module_put(hw->card->module); + module_put(mod); return err; } |