summaryrefslogtreecommitdiff
path: root/drivers/staging/xgifb
AgeCommit message (Collapse)Author
2011-07-05Remove unneeded version.h includes from drivers/staging/xgifb/Jesper Juhl
It was pointed out by 'make versioncheck' that some includes of linux/version.h are not needed in drivers/staging/xgifb/. This patch removes them. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-26Staging: xgifb: Fixed style issues.Kenji Toyama
Not all warnings/errors were silenced, some of them are related to simple printk() messages that imho should not be split across multiple lines (it makes it harder to grep for example), and some of them are related to long lines that are pretty much impossible to split without proper code refactoring. Resubmitting this patch because of conflicts. Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-26Staging: xgifb: Fixed style issues.Kenji Toyama
Now there's only 10 errors and 1 warning given by checkpatch.pl, and these are related initialization of statics. The only warning left can be safely ignored I believe. I'm resending this patch as the previous one was conflicting with the newer version updated by Aaro Koskinen. Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25Staging: xgifb: Fixed styles issues.Kenji Toyama
All the warnings about styles have been removed. Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25Staging: xgifb: Fixed style issues.Kenji Toyama
Now checkpatch.pl doesn't complain about vgatypes.h. Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25Staging: xgifb: Fixed header file.Kenji Toyama
As suggested by checkpatch.pl, <linux/io.h> should be used instead of <asm/io.h>. Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25Staging: xgifb: Removed thousands of warnings.Kenji Toyama
This is a big patch to remove all the warnings given by checkpatch.pl. There were 13348 errors and 3112 warnings, but now there's nothing. I've compiled the files dependent on this header and they seem alright. Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25Staging: xgifb: Fixed almost all style warnings.Kenji Toyama
I've removed all the warnings except one that I believe is a false positive. The original author has used a macro to #define EXTERN to be 'extern', so in this case 'extern' is not used to define the storage class of anything, but just the value of the macro. We can safely ignore this warning. Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25Staging: xgifb: Fixed lots of coding style issues.Kenji Toyama
There were hundreds of warnings and errors given by checkpatch.pl but now it's down to 20. These ones that were left in the code need some more attention, cause I reckon the functions are overly nested leading to a mess of code in a traditional 80 character screen. I'm sure this code can be refactored into something more visually pleasing (things like compressing two nested if's into a single if with an AND would help a lot already). Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25Staging: xgifb: Fixed coding style issues in vb_setmode.hKenji Toyama
All the warnings in vb_setmode.h given by checkpatch.pl were removed. Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25Staging: xgifb: Fixed lots of coding style issues.Kenji Toyama
There were hundreds of warnings, but now there's only four. These are related to the 'volatile' keyword and printk(), which I think should be left to the maintainers to modify if deemed necessary. Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25Staging: xgifb: Fixed coding style issues.Kenji Toyama
Not all warnings were silenced. One of them is a typedef in vb_ext.h which I think seems alright. The other warnings in vb_ext.c I left there because that would involve changing a bit of the logic in the code. IMHO though I think the functions are too complicated (i.e. the if/else are too deep within a big function.) and can probably be split. Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25Staging: xgifb: Fixed coding style issues in vb_def.hKenji Toyama
I've removed all the warnings given by checkpatch.pl in vb_def.h and also changed the indentation of pretty much the entire file so that it is more consistent. Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25staging: xgifb: main: make internal functions staticAaro Koskinen
Make remaining non-static internal functions static. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25staging: xgifb: main: delete unused functionsAaro Koskinen
Delete unused/dead code. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25staging: xgifb: main: delete redudant extern declarationsAaro Koskinen
Delete redudant declarations and include proper .h files. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25staging: xgifb: main: move functions to avoid forward declarationsAaro Koskinen
Move functions so that all forward declarations of internal functions can be deleted. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25staging: xgifb: delete unused register I/O functionsAaro Koskinen
Delete unused register I/O functions. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25staging: xgifb: delete unused register I/O macrosAaro Koskinen
Delete unused register I/O macros. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25staging: xgifb: replace setXGIIDXREG() with xgifb_reg_and_or()Aaro Koskinen
Replace setXGIIDXREG() with xgifb_reg_and_or(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25staging: xgifb: replace andXGIIDXREG() with xgifb_reg_and()Aaro Koskinen
Replace andXGIIDXREG() with xgifb_reg_and(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25staging: xgifb: replace orXGIIDXREG() with xgifb_reg_or()Aaro Koskinen
Replace orXGIIDXREG() with xgifb_reg_or(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25staging: xgifb: replace outXGIIDXREG() with xgifb_reg_set()Aaro Koskinen
Replace outXGIIDXREG() with xgifb_reg_set(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25staging: xgifb: replace inXGIIDXREG() with xgifb_reg_get()Aaro Koskinen
Replace inXGIIDXREG() with xgifb_reg_get(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25staging: xgifb: replace outXGIREG() with outb()Aaro Koskinen
Replace outXGIREG() with outb(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-31Fix common misspellingsLucas De Marchi
Fixes generated by 'codespell' and manually reviewed. Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
2011-03-14staging: xgifb: clean up register function variable namesAaro Koskinen
Eliminate mixed case from variable names. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: clean up register access typesAaro Koskinen
Make type usage consistent. Use u8 for HW registers and unsigned for bitmasks. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: rename XGINew_SetRegAND() to xgifb_reg_and()Aaro Koskinen
Rename XGINew_SetRegAND() to xgifb_reg_and(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: rename XGINew_SetRegANDOR() to xgifb_reg_and_or()Aaro Koskinen
Rename XGINew_SetRegANDOR() to xgifb_reg_and_or(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: rename XGINew_SetRegOR() to xgifb_reg_or()Aaro Koskinen
Rename XGINew_SetRegOR() to xgifb_reg_or(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: rename XGINew_GetReg1() to xgifb_reg_get()Aaro Koskinen
Rename XGINew_GetReg1() to xgifb_reg_get(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: rename XGINew_SetReg1() to xgifb_reg_set()Aaro Koskinen
Rename XGINew_SetReg1() to xgifb_reg_set(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: replace XGINew_SetReg4() with outl()Aaro Koskinen
Replace XGINew_SetReg4() with outl(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: replace XGINew_SetReg3() with outb()Aaro Koskinen
Replace XGINew_SetReg3() with outb(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: replace XGINew_GetReg3() with inl()Aaro Koskinen
Replace XGINew_GetReg3() with inl(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: replace XGINew_GetReg2() with inb()Aaro Koskinen
Replace XGINew_GetReg2() with inb(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: vb_util: delete commented-out codeAaro Koskinen
Delete commented-out code. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: vb_util: include the .h fileAaro Koskinen
Include the .h file and delete redundant definitions. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: replace DelayUS() with udelay()Aaro Koskinen
Replace DelayUS() with udelay(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: use mdelay() for millisecond delaysAaro Koskinen
Use mdelay() instead of udelay() for millisecond delays. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: delete incorrect I/O mappingAaro Koskinen
If the PCI device was disabled when the probe() routine started, the driver will create 256 MB video memory mapping which is never used or properly released. It's also unsafe as the size is incorrect for many video cards. Deleting it also allows eliminating XGIvga_enable global variable. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: delete redundant extended register access enableAaro Koskinen
The extended register access enable in !XGIvga_enabled case is not needed. The driver has enabled the access unconditionally already earlier in the routine. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: delete unused LINUXBIOS codeAaro Koskinen
Delete unused LINUXBIOS code. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: eliminate redudant chip type >= XG40 checksAaro Koskinen
Since all chips supported by the driver are >= XG40, these checks are redundant and the code can be modified accordingly. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: delete dead code for chip types < XG40Aaro Koskinen
XG40 is the first supported chip, so the code for earlier chips can be dropped. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: delete unsupported chip typesAaro Koskinen
The probe routine will fail if the chip is other than XG40..XG27, so the other types can be dropped. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: vb_setmode: move functions to avoid forward declarationsAaro Koskinen
Move functions to avoid forward declarations. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: vb_init: move functions to avoid forward declarationsAaro Koskinen
Move functions to avoid forward declarations. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14staging: xgifb: vb_ext: move functions to avoid forward declarationsAaro Koskinen
Move functions to avoid forward declarations. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
generated by cgit v1.2.3 (git 2.0.4) at 2024-05-21 05:59:42 +0000