From 2a211f320ee3d86835b40efd2948642482d3c933 Mon Sep 17 00:00:00 2001 From: Himangi Saraogi Date: Sat, 12 Jul 2014 01:12:43 +0530 Subject: thunderbolt: Use kcalloc The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall Acked-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman --- drivers/thunderbolt/nhi.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'drivers/thunderbolt') diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index ce72f31fe0d8..c68fe1222c16 100644 --- a/drivers/thunderbolt/nhi.c +++ b/drivers/thunderbolt/nhi.c @@ -569,12 +569,10 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id) nhi->hop_count); INIT_WORK(&nhi->interrupt_work, nhi_interrupt_work); - nhi->tx_rings = devm_kzalloc(&pdev->dev, - nhi->hop_count * sizeof(*nhi->tx_rings), - GFP_KERNEL); - nhi->rx_rings = devm_kzalloc(&pdev->dev, - nhi->hop_count * sizeof(*nhi->rx_rings), - GFP_KERNEL); + nhi->tx_rings = devm_kcalloc(&pdev->dev, nhi->hop_count, + sizeof(*nhi->tx_rings), GFP_KERNEL); + nhi->rx_rings = devm_kcalloc(&pdev->dev, nhi->hop_count, + sizeof(*nhi->rx_rings), GFP_KERNEL); if (!nhi->tx_rings || !nhi->rx_rings) return -ENOMEM; -- cgit v1.2.3