From 4cf940113a3cd4e88aae12f7b4d9e218002204e8 Mon Sep 17 00:00:00 2001 From: Pradeep Goudagunta Date: Fri, 12 Aug 2011 16:00:38 +0530 Subject: serial: tegra: Add check for uart state before access Add proper check for uart state in public api to make sure client driver would not access UART registers when it is in invalid state. Bug 827693 Original-Change-Id: Icfaed824d98023206dacd0346a90e34f2fc6935e Reviewed-on: http://git-master/r/46923 Tested-by: Pradeep Goudagunta Reviewed-by: Laxman Dewangan Rebase-Id: R9fc0c9d47aae00785b92617ac6b03ab743fcb07d --- drivers/tty/serial/tegra_hsuart.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'drivers/tty') diff --git a/drivers/tty/serial/tegra_hsuart.c b/drivers/tty/serial/tegra_hsuart.c index 222b9678610f..26e9948e6bc1 100644 --- a/drivers/tty/serial/tegra_hsuart.c +++ b/drivers/tty/serial/tegra_hsuart.c @@ -931,6 +931,10 @@ static void tegra_set_mctrl(struct uart_port *u, unsigned int mctrl) dev_dbg(u->dev, "tegra_set_mctrl called with %d\n", mctrl); t = container_of(u, struct tegra_uart_port, uport); + if (t->uart_state != TEGRA_UART_OPENED) { + dev_err(t->uport.dev, "Uart is in invalid state\n"); + return; + } mcr = t->mcr_shadow; if (mctrl & TIOCM_RTS) { -- cgit v1.2.3