From 4b046dd35262ad03b0e764c4158e49cb17ca4352 Mon Sep 17 00:00:00 2001 From: Pavan Kunapuli Date: Fri, 4 May 2012 18:23:56 +0530 Subject: mmc: core: Abort failed transfer before retries Retries should be done only after abort command is issued for the current failed transfer. The block layer already has an implementation for retrying. No need for the extra retries. Bug 961761 Bug 922239 Change-Id: I07f60e85e093b725007727833739013f8fd66d43 Signed-off-by: Pavan Kunapuli Reviewed-on: http://git-master/r/100563 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: Bitan Biswas --- drivers/mmc/card/block.c | 3 --- drivers/mmc/core/core.c | 5 ----- 2 files changed, 8 deletions(-) (limited to 'drivers') diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index 2bd93d7a5170..bd5427d1f9e3 100644 --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c @@ -59,8 +59,6 @@ MODULE_ALIAS("mmc:block"); #define INAND_CMD38_ARG_SECTRIM1 0x81 #define INAND_CMD38_ARG_SECTRIM2 0x88 -#define MMC_CMD_RETRIES 10 - static DEFINE_MUTEX(block_mutex); /* @@ -945,7 +943,6 @@ static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq, if (!mmc_card_blockaddr(card)) brq->cmd.arg <<= 9; brq->cmd.flags = MMC_RSP_SPI_R1 | MMC_RSP_R1 | MMC_CMD_ADTC; - brq->cmd.retries = MMC_CMD_RETRIES; brq->data.blksz = 512; brq->stop.opcode = MMC_STOP_TRANSMISSION; brq->stop.arg = 0; diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 2a288e936a84..c5338cd45aa7 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -109,11 +109,6 @@ void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq) cmd->retries--; cmd->error = 0; - if (mrq->data) { - mrq->data->error = 0; - if (mrq->stop) - mrq->stop->error = 0; - } host->ops->request(host, mrq); } else { led_trigger_event(host->led, LED_OFF); -- cgit v1.2.3