diff options
| author | Mike Snitzer <snitzer@redhat.com> | 2014-03-21 15:54:03 -0400 |
|---|---|---|
| committer | Stefan Agner <stefan@agner.ch> | 2015-09-01 14:44:38 -0700 |
| commit | b58a60eb42c0c90f7b61277ebcc4fcf2b8573fd2 (patch) | |
| tree | 1f68b09f8ccaab415c1f84c4b846f617d8e22303 | |
| parent | 08c70ad7fea209f8f1b954d3f53314859d8aa5b8 (diff) | |
UBI: fix rb_tree node comparison in add_map
The comparisons used in add_vol() shouldn't be identical. Pretty sure
the following is correct but it is completely untested.
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Acked-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
| -rw-r--r-- | drivers/mtd/ubi/fastmap.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index a2166e431c..c039dfeec7 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -127,9 +127,9 @@ static struct ubi_ainf_volume *add_vol(struct ubi_attach_info *ai, int vol_id, parent = *p; av = rb_entry(parent, struct ubi_ainf_volume, rb); - if (vol_id > av->vol_id) + if (vol_id < av->vol_id) p = &(*p)->rb_left; - else if (vol_id > av->vol_id) + else p = &(*p)->rb_right; } |