diff options
| author | Brian Norris <computersforpeace@gmail.com> | 2014-05-20 22:35:38 -0700 |
|---|---|---|
| committer | Stefan Agner <stefan@agner.ch> | 2015-09-01 14:45:51 -0700 |
| commit | def23617b4e6c1325d9d1c598d849575d2284b55 (patch) | |
| tree | c294aa21134a05e23851bea5c2db501df2c958f2 | |
| parent | 394ca0f4fd77f56b0be3dd19e9a331c4bc182b82 (diff) | |
UBI: fastmap: do not miss bit-flips
The return value from 'ubi_io_read_ec_hdr()' was stored in 'err', not in 'ret'.
This fix makes sure Fastmap-enabled UBI does not miss bit-flip while reading EC
headers, events and scrubs the affected PEBs.
This issue was reported by Coverity Scan.
Artem: improved the commit message.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Acked-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
| -rw-r--r-- | drivers/mtd/ubi/fastmap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index e06366bc2f..2317a0e5f7 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -431,7 +431,7 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai, pnum, err); ret = err > 0 ? UBI_BAD_FASTMAP : err; goto out; - } else if (ret == UBI_IO_BITFLIPS) + } else if (err == UBI_IO_BITFLIPS) scrub = 1; /* |